Windows 10: code execution

keep getting MSVCR100.dll when trying to install games

:)

 

8-puzzle code executes infinitely.

Your solution works! make these changes. Just change comment the first two line of equals and yo did not change the Code: public void equals(EightPuzzle test)[/quote] to Code: public void equals(Object test)[/quote] Now it executes withing 1 second for all the inputs. Superb optimization. Thanks*Smile
But I would like to get things clarified.
You have made the following changes :

• in astar() you changed Code: EightPuzzle x = openset.seek();[/quote] to Code: EightPuzzle x = openset.poll();[/quote] .This way you could removed the burden of first peeking and then polling.

• 
  in astar() you converted Code: if(closedset.contains(y)){ continue; } if(!closedset.contains(y)){ openset.add(y); }[/quote] to Code: if (closedset.contains(y)) { continue; } openset.add(y);[/quote] This removed the burden of calling contains two times. Instead you called it only once.

• BUT in public LinkedList getChildren() of EightPuzzle you just kept one EightPuzzle variable called unified instead of up,right,down,left. And you changed the if statements to do while. Did you make these two change to save memory or does it also make the execution faster? If yes how did these two changes make the execution faster?

4)

 

8-puzzle code executes infinitely.

Without running this in a debugger or seeing actual values as the code executes, this is a bit hard to do in one's head. lol

Given that the first code snippet you posted is where the infinite loop is occurring, it looks one of the two while loops is never returning a false value and exiting.

The While(neighbor.size() > 0) loop doesn't look like the problem as you are removing the head of the list and never putting anything back into it in the loop.

This would cause me to look at the openset.size() value as the code is running. If a situation occurs where after you remove the head of the list (with the openset.poll() call) another node is always being added by the openset.add() call inside the nested while loop, the size of openset would never reach zero and thus loop forever.

I could, of course, be totally confused and wrong. *Big Grin

 

8-puzzle code executes infinitely.

Bingo, you go from linear time to constant time. Huge performance benefits for large data sets.

Ahh, right. The object class should be smart enough to use all of the object attributes, but you may want to override it since it could most likely be executed faster. That makes sense, I missed that one. I only spent a little while looking through and editing code.